Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify conditionals codegen + add missing side effects checks. #7151

Merged
merged 10 commits into from
Nov 10, 2024
+178 −176
Merged

Simplify conditionals codegen + add missing side effects checks. #7151

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c9c49f0
Simplify conditionals.
cristianoc Nov 8, 2024
2dad032
Update CHANGELOG.md
cristianoc Nov 8, 2024
0d49895
Squeeze in side effects check
cristianoc Nov 8, 2024
8bb3473
comment
cristianoc Nov 8, 2024
30a6b2d
Only apply optimisations when there are no side effects.
cristianoc Nov 9, 2024
c0e5b78
More side effects.
cristianoc Nov 10, 2024
00b9b92
More side effect cases.
cristianoc Nov 10, 2024
90f7e9b
dead code
cristianoc Nov 10, 2024
1a5f286
Add example of what was previously over-optimized.
cristianoc Nov 10, 2024
6d4c212
Update CHANGELOG.md
cristianoc Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Update CHANGELOG.md
@cristianoc
cristianoc committed Nov 8, 2024
commit 2dad0322838230710998514e59773f240eb22164
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -63,6 +63,7 @@
- Improve pattern matching on optional fields. https://github.com/rescript-lang/rescript-compiler/pull/7143 https://github.com/rescript-lang/rescript-compiler/pull/7144
- Optimize compilation of switch statements for untagged variants when there are no literal cases. https://github.com/rescript-lang/rescript-compiler/pull/7135
- Further improve boolean optimizations. https://github.com/rescript-lang/rescript-compiler/pull/7149
- Simplify code generated forconditionals. https://github.com/rescript-lang/rescript-compiler/pull/7151


#### :house: Internal