Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from Location and Rescript_cpp modules #7150

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Nov 7, 2024

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: a5c09df Previous: e1b7fb7 Ratio
Print RedBlackTree.res - time/run 2.4575537866666664 ms 2.3104395133333333 ms 1.06
Print RedBlackTreeNoComments.res - time/run 2.2506460133333333 ms 2.10057036 ms 1.07

This comment was automatically generated by workflow using github-action-benchmark.

@cknitt cknitt requested review from zth and cristianoc December 13, 2024 14:29
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@cknitt cknitt changed the title Remove unused stuff from Location and Rescript_cpp modules Remove unused code from Location and Rescript_cpp modules Dec 14, 2024
@cknitt cknitt merged commit 81a5081 into master Dec 14, 2024
20 checks passed
@cknitt cknitt deleted the remove-unused branch December 14, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants