Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional fields pattern matching: untagged variants #7144

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

cristianoc
Copy link
Collaborator

Add support for untagged variants to optimised pattern matching for optional fields.

Add support for untagged variants to optimised pattern matching for optional fields.
@cristianoc cristianoc requested review from cknitt and zth November 2, 2024 07:55
@cknitt
Copy link
Member

cknitt commented Nov 2, 2024

👍 For reference, what would the output for the new example have looked like before this change?

And interesting - why is it checking for id === null, but not for name === null?

Is it possible to further simplify to something like

function decodeGroup(group) {
  let id = group.id;
  let name = group.name;

  if (typeof id !== "string" || typeof name !== "string") {
    return [
      "e",
      "f"
    ];
  } else {
    return [
      id,
      name
    ];
  }
}

@cristianoc
Copy link
Collaborator Author

👍 For reference, what would the output for the new example have looked like before this change?

And interesting - why is it checking for id === null, but not for name === null?

Is it possible to further simplify to something like

function decodeGroup(group) {
  let id = group.id;
  let name = group.name;

  if (typeof id !== "string" || typeof name !== "string") {
    return [
      "e",
      "f"
    ];
  } else {
    return [
      id,
      name
    ];
  }
}

Same answer to both: it's an artifact the pattern matching algorithm.
Which hasn't changed yet, but will in #7135

@cristianoc cristianoc merged commit 1a3efbe into master Nov 2, 2024
20 checks passed
@cristianoc cristianoc deleted the pm-opt-untagged branch November 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants