Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplfy e?true:false to e #7139

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Simplfy e?true:false to e #7139

merged 1 commit into from
Oct 31, 2024

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc requested a review from cknitt October 31, 2024 14:34
@cristianoc cristianoc mentioned this pull request Oct 31, 2024
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Small change with a big impact! 😀

@@ -7,7 +7,7 @@ function shouldHandleNullableValues() {
let tUndefined = undefined;
let tValue = "hello";
let tmp;
tmp = tNull === null ? true : false;
tmp = tNull === null || tNull === undefined ? tNull === null : false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tNull === undefined was already gone in #7138?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge and rebase directly on #7138

@cristianoc cristianoc merged commit e07ee33 into negation Oct 31, 2024
@cristianoc cristianoc deleted the if-then-else branch October 31, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants