Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated top-level suffix in the rescript.json #7056

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Deprecated top-level suffix in the rescript.json #7056

merged 3 commits into from
Oct 11, 2024

Conversation

cometkim
Copy link
Member

This is a required change for "dual" package specs

See #6209 (comment)

cknitt
cknitt reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I would just suggest slightly improved wording of the deprecation message:

The "suffix" option at the top level is deprecated. Move the "suffix" setting into each "package-specs" entry.

@fhammerschmidt fhammerschmidt mentioned this pull request Oct 8, 2024
Open
5 tasks
@cometkim cometkim force-pushed the deprecated-top-level-suffix branch from 0761aaa to e68725b Compare October 11, 2024 13:36
@cometkim cometkim requested a review from cknitt October 11, 2024 13:36
cknitt
cknitt approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cometkim cometkim merged commit 6de936a into rescript-lang:11.0_release Oct 11, 2024
14 checks passed
@cometkim cometkim deleted the deprecated-top-level-suffix branch October 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

@cristianoc cristianoc Awaiting requested review from cristianoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cometkim @cknitt