Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FORCE_COLOR environmental variable to force colorized output #7033

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

mediremi
Copy link
Contributor

@mediremi mediremi commented Sep 11, 2024

With the move from the ninja-based build system to rewatch, it makes sense to replace NINJA_ANSI_FORCED with FORCE_COLOR to force colorized output.

This PR also fixes rescript_bsb.js not having a way to force colorized output.

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good to me.

@zth Ok to go with FORCE_COLOR?

@zth
Copy link
Collaborator

zth commented Sep 12, 2024

@cknitt sure, sounds great!

@cknitt
Copy link
Member

cknitt commented Sep 12, 2024

Great! Could you add a CHANGELOG entry @mediremi?

@mediremi mediremi marked this pull request as ready for review September 12, 2024 11:32
@mediremi
Copy link
Contributor Author

@cknitt changelog entry added 👍

@cknitt cknitt merged commit 8120131 into rescript-lang:master Sep 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants