Coerce polyvariant to variant #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Aug 26, 2024
| @@ -3701,6 +3701,14 @@ let rec subtype_rec env trace t1 t2 cstrs = | |||
| with Exit -> | |||
| (trace, t1, t2, !univar_pairs)::cstrs | |||
| end | |||
| | (Tvariant {row_closed=true; row_fields}, Tconstr (_, [], _)) | |||
| when extract_concrete_typedecl_opt env t2 |> Variant_coercion.type_is_variant -> | |||
There was a problem hiding this comment.
I wonder if there's a better way to do this. I had to check that it's an actual variant, or the case under would be blocked, which broke a coercion test.
There was a problem hiding this comment.
@cristianoc anything else we should check for here? Private?
There was a problem hiding this comment.
Private does not change the internal representation, so I would not bother.
zth
force-pushed
the
coerce-polyvariant-to-variant
branch
from
e1ddefd to
40a31f1
Compare
zth
force-pushed
the
coerce-polyvariant-to-variant
branch
from
40a31f1 to
0eb44ef
Compare
|
@cristianoc ready for review. |
cristianoc
approved these changes
Aug 27, 2024
| @@ -3701,6 +3701,14 @@ let rec subtype_rec env trace t1 t2 cstrs = | |||
| with Exit -> | |||
| (trace, t1, t2, !univar_pairs)::cstrs | |||
| end | |||
| | (Tvariant {row_closed=true; row_fields}, Tconstr (_, [], _)) | |||
| when extract_concrete_typedecl_opt env t2 |> Variant_coercion.type_is_variant -> | |||
There was a problem hiding this comment.
Private does not change the internal representation, so I would not bother.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to coerce from polyvariant to variant when we can guarantee the runtime representations will match.