Improve extension creation runtime

[DZakh]

Also, removed /1 for RE_EXN_ID created the first time

[cknitt]

What's the advantage of using Dict vs. Map?

[DZakh]

What's the advantage of using Dict vs. Map?

It's faster and simpler

[cknitt]

Is it really faster?

This article here seems to suggest otherwise:
https://rehmat-sayany.medium.com/using-map-over-objects-in-javascript-a-performance-benchmark-ff2f351851ed

Typical applications should not create that many different exception types anyway though, so it probably doesn't matter much?

[DZakh]

Is it really faster?

This article here seems to suggest otherwise: https://rehmat-sayany.medium.com/using-map-over-objects-in-javascript-a-performance-benchmark-ff2f351851ed

Typical applications should not create that many different exception types anyway though, so it probably doesn't matter much?

I don't know about the benchmark, but according to my knowledge {} may run in different optimisation modes depending on the number of keys and can drastically slow down when there are more than 20 or something like this. But Map uses the same representation under the hood which is even more complex, since it needs to support objects as keys and many iteration methods + every set and get is a function call.

And in the benchmark you can see that it's 20 times slower:

https://jsbenchmark.com/#eyJjYXNlcyI6W3siaWQiOiJzbFZZeUNzc2dKUG1VREE5RDdieEQiLCJjb2RlIjoiREFUQS5tYXAuc2V0KFwiZm9vXCIsIDEpXG5EQVRBLm1hcC5zZXQoXCJmb29cIiwgMilcbkRBVEEubWFwLnNldChcImJhclwiLCAxKVxuREFUQS5tYXAuc2V0KFwiYmF6XCIsIERBVEEubWFwLmdldChcImZvb1wiKSkiLCJuYW1lIjoibWFwIiwiZGVwZW5kZW5jaWVzIjpbXX0seyJpZCI6IkloVjEyMjJzekxVa2wzazZQanc1ZCIsImNvZGUiOiJEQVRBLmRpY3RbXCJmb29cIl0gPSAxXG5EQVRBLmRpY3RbXCJmb29cIl0gPSAyXG5EQVRBLmRpY3RbXCJiYXJcIl0gPSAxXG5EQVRBLmRpY3RbXCJiYXpcIl0gPSBEQVRBLmRpY3RbXCJmb29cIl0iLCJuYW1lIjoiZGljdCIsImRlcGVuZGVuY2llcyI6W119XSwiY29uZmlnIjp7Im5hbWUiOiJCYXNpYyBleGFtcGxlIiwicGFyYWxsZWwiOnRydWUsImdsb2JhbFRlc3RDb25maWciOnsiZGVwZW5kZW5jaWVzIjpbXX0sImRhdGFDb2RlIjoicmV0dXJuIHtcbiAgbWFwOiBuZXcgTWFwKCksXG4gIGRpY3Q6IHt9XG59In19

[DZakh]

[cknitt]

And in the benchmark you can see that it's 20 times slower:

😱 Then that makes a lot of sense of course. Not sure what the guy in that medium article benchmarked with. This jsbenchmark.com is nice BTW.

@cristianoc Are the changes fine with you, too?

[cknitt]

LGTM! Thanks a lot!