Differentiate exception extensions #6954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZakh
force-pushed
the
differentiate-exception-extensions
branch
from
2c7cf89 to
e6e56ff
Compare
|
This |
|
Would you add a description on top of the PR indicating what it does? |
Done |
cometkim
approved these changes
Aug 20, 2024
cknitt
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ext_is_exceptionfield to theextension_constructortype. It can be used to differentiate between exceptions and normal extension types. Currently used in one place for error message (the place existed before, made it use theext_is_exceptioninstead of figuring out it itself).I believe the change is the first step to split extension types and exceptions representations.