Remove constant flag from extension constructor #6943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would you rebase on master? |
|
@DZakh Could you rebase and add a changelog entry so that we can get this merged? |
DZakh
force-pushed
the
remove-constant-flag-from-extension-constructor
branch
from
5ca5069 to
b08b44a
Compare
DZakh
force-pushed
the
remove-constant-flag-from-extension-constructor
branch
from
b08b44a to
9a65856
Compare
|
@cknitt Done. I don't see a need in changelog, since it simply removes unused code |
We have other cleanups listed under internal, too, but ok, maybe it's not worth it for this one. |
cknitt
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #6942 with the additional removal of the constant flag, which became unneeded