New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: avoid JS identifier #6839

Merged

cknitt merged 1 commit into rescript-lang:master from cometkim:avoid-keyword

Jun 29, 2024

Member

cometkim commented Jun 28, 2024

package is a reserved identifier in JavaScript. should throw SyntaxError in strict mode.

Switch to Biome #6838 Biome can audit this kind of problems
I'm migrating the codebase to ESM, which is in strict mode by default.


          avoid JS identifier

9c5c352

cknitt approved these changes

View reviewed changes

cknitt merged commit 73182ec into rescript-lang:master

20 checks passed

cometkim deleted the avoid-keyword branch

June 29, 2024 17:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet