Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish tagged template literals #6645

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

tsnobip
Copy link
Contributor

@tsnobip tsnobip commented Feb 20, 2024

Allow modules in tagged template literals

Allow to write this:

let taggedTemplate = Pg.sql`select * from ${table} where id = ${id}`

Fix reexport tagged template externals

Without this fix, when reexporting tagged template external bindings, it would raise

File "jscomp/core/lam_compile_external_call.ml", line 262, characters 17-23: Assertion failed

@tsnobip tsnobip force-pushed the fix_reexport_tagged_template_external branch from d6f2e0f to eb7ebfc Compare February 20, 2024 17:04
@tsnobip tsnobip marked this pull request as ready for review February 20, 2024 17:04
@tsnobip tsnobip enabled auto-merge (rebase) February 20, 2024 17:04
@tsnobip tsnobip requested a review from zth February 20, 2024 17:05
@tsnobip tsnobip changed the title Fix reexport tagged template externals Polish tagged template literals Feb 20, 2024
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just one small comment as you can see.

@tsnobip tsnobip force-pushed the fix_reexport_tagged_template_external branch from a6b0576 to dc77414 Compare February 20, 2024 18:09
@zth zth disabled auto-merge February 20, 2024 18:10
@tsnobip tsnobip force-pushed the fix_reexport_tagged_template_external branch from dc77414 to efe0b5e Compare February 20, 2024 18:14
@tsnobip tsnobip enabled auto-merge (rebase) February 20, 2024 18:15
@tsnobip tsnobip merged commit 6cb8471 into 11.0_release Feb 20, 2024
13 checks passed
@zth zth deleted the fix_reexport_tagged_template_external branch February 20, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants