Fix inline comment before spread syntax in record #6615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shulhi
force-pushed
the
fix/record-spread-comment
branch
from
6f9395c to
b06544f
Compare
shulhi
commented
Feb 8, 2024
| @@ -125,7 +125,7 @@ let user = /* before */ { | |||
| } // after | |||
|
|
|||
| let spreadUser = { | |||
| .../* before */ user1 /* after */, | |||
| /* before */ ...user1 /* after */, | |||
There was a problem hiding this comment.
This is the only place where the formatting will change. The spread (...) operator and the ident are matched together. I think it makes sense than allowing comment to be placed in between them.
|
@zth mind reviewing this when you have a chance? |
|
@cknitt you worked a bit with the comments, right? Could you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6506