Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle doc comment in recursive module #6613

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Handle doc comment in recursive module #6613

merged 3 commits into from
Feb 6, 2024

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented Feb 6, 2024

Fix #6598

@zth
Copy link
Collaborator

zth commented Feb 6, 2024

Awesome! Could you add a test as well?

@shulhi
Copy link
Member Author

shulhi commented Feb 6, 2024

Awesome! Could you add a test as well?

Sure thing!

@zth
Copy link
Collaborator

zth commented Feb 6, 2024

@shulhi also:

  • Add a changelog
  • Rebase (and change the base branch) to 11.0_release

Then we're good to go! 😄

@shulhi shulhi force-pushed the fix/rec-module-doccomment branch from 6b99fab to 6d6ec47 Compare February 6, 2024 12:02
@shulhi shulhi changed the base branch from master to 11.0_release February 6, 2024 12:03
@zth zth self-requested a review February 6, 2024 12:08
@zth zth merged commit 3f22f9a into rescript-lang:11.0_release Feb 6, 2024
@zth zth mentioned this pull request Feb 6, 2024
Closed
@shulhi shulhi deleted the fix/rec-module-doccomment branch February 7, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc comment syntax (/** */) is not working when attached to recursive modules
2 participants
@shulhi @zth