Fix renamed field access in inline records #6551
Conversation
jscomp/test/as_inline_record_test.js
Outdated
| @@ -6,10 +6,18 @@ function getName(t) { | |||
| return t.renamed; | |||
| } | |||
|
|
|||
| function getName$p(t) { | |||
| return t.name; | |||
There was a problem hiding this comment.
you can see the error here, should be:
| return t.name; | |
| return t.renamed; |
|
Just adding the functions doesn't work, you need to actually call them https://github.com/melange-re/melange-compiler-libs/pull/26/files |
you're the best @anmonteiro, thanks a lot, it's working now! |
tsnobip
changed the title
tsnobip
force-pushed
the
renamed_inline_record_field_access
branch
from
9419c6d to
6a2c168
Compare
CONTRIBUTING.md
Outdated
|
|
||
| Bug fixes and maintenance should target branch `11.0_release`. | ||
| We'll merge `11.0_release` into `master` from time to time to propagate those changes. | ||
|
|
tsnobip
force-pushed
the
renamed_inline_record_field_access
branch
from
328b3c9 to
afd2b59
Compare
| @@ -59,6 +75,15 @@ let blk_record (fields : (label * _) array) mut record_repr = | |||
| Lambda.Blk_record | |||
| { fields = all_labels_info; mutable_flag = mut; record_repr } | |||
|
|
|||
| let blk_record_ext fields mutable_flag = | |||
There was a problem hiding this comment.
Looks like this function is assigned to a reference but never used elsewhere?
There was a problem hiding this comment.
it is used in translcore in translcore on line 1240
| @@ -46,8 +46,13 @@ let setup_env () = | |||
| Record_attributes_check.check_duplicated_labels; | |||
| Lambda.fld_record := Record_attributes_check.fld_record; | |||
| Lambda.fld_record_set := Record_attributes_check.fld_record_set; | |||
| Lambda.fld_record_inline := Record_attributes_check.fld_record_inline; | |||
There was a problem hiding this comment.
All this indirection with references seems unnecessary.
It was probably used a long time ago to keep the standard version of the compiler, but currently there's only 1 version of the compiler used.
There was a problem hiding this comment.
So I should just use direct bindings? OK I'll adapt the PR
tsnobip
force-pushed
the
renamed_inline_record_field_access
branch
from
21eebc3 to
6112b5b
Compare
Fixes #6549.
As suggested by @anmonteiro in his comment of issue #6438, I started with adding the remaining part from melange-re/melange#732
, but this is not enough.Edit: it works now :)