GenType: fix issue with @as("0") and other numbers. #6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some special code in the type emitter to take care of poly variants of the form e.g. `#0`, which is represented internally as the string "0".
This conflicts with normal variants annotated with `@as("0")` and such.
This PR resolves the case of numeric poly variants early on, and removes the special casing in the code emitter.
Fixes #6486
cristianoc
force-pushed
the
gentype_as_number
branch
from
dfdfb78 to
e442658
Compare
5 tasks
zth
reviewed
Nov 20, 2023
| type t = Array(array<int>) | Record({x: int}) | Function((. int) => int) | ||
|
|
||
| @genType | ||
| type tabIndex = | @as("0") Activity | @as("1") UserKeyword |
There was a problem hiding this comment.
Maybe add a test for @as(0) too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some special code in the type emitter to take care of poly variants of the form e.g.
#0, which is represented internally as the string "0". This conflicts with normal variants annotated with@as("0")and such.This PR resolves the case of numeric poly variants early on, and removes the special casing in the code emitter.
Fixes #6486