Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency stdlib-406 -> belt #6453

Merged
merged 1 commit into from
Oct 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
- Fix printing of exotic JSX names https://github.com/rescript-lang/rescript-compiler/pull/6451
- Fix locations when code with `await` fails to compile (all locations would point to the internal function `unsafe_await`) https://github.com/rescript-lang/rescript-compiler/pull/6452

#### :house: Internal

- Remove dependency stdlib-406 -> belt. https://github.com/rescript-lang/rescript-compiler/pull/6453

#### :nail_care: Polish

- Add [`Deno`](https://deno.land/api?s=Deno) to reserved names, so that modules named `Deno` don't clash with the globally exposed `Deno` object. https://github.com/rescript-lang/rescript-compiler/pull/6428
Expand Down
4 changes: 2 additions & 2 deletions jscomp/stdlib-406/release.ninja
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ o stdlib-406/stdLabels.cmj : cc_cmi stdlib-406/stdLabels.res | stdlib-406/arrayL
o stdlib-406/stdLabels.cmi : cc stdlib-406/stdLabels.resi | stdlib-406/arrayLabels.cmi stdlib-406/bytesLabels.cmi stdlib-406/listLabels.cmi stdlib-406/pervasives.cmj stdlib-406/stringLabels.cmi $bsc others
o stdlib-406/stream.cmj : cc_cmi stdlib-406/stream.res | stdlib-406/bytes.cmj stdlib-406/lazy.cmj stdlib-406/list.cmj stdlib-406/stream.cmi stdlib-406/string.cmj $bsc others
o stdlib-406/stream.cmi : cc stdlib-406/stream.resi | stdlib-406/pervasives.cmj $bsc others
o stdlib-406/string.cmj : cc_cmi stdlib-406/string.res | stdlib-406/bytes.cmj stdlib-406/string.cmi $bsc others
o stdlib-406/string.cmj : cc_cmi stdlib-406/string.res | stdlib-406/array.cmj stdlib-406/bytes.cmj stdlib-406/string.cmi $bsc others
o stdlib-406/string.cmi : cc stdlib-406/string.resi | stdlib-406/pervasives.cmj $bsc others
o stdlib-406/stringLabels.cmj : cc_cmi stdlib-406/stringLabels.res | stdlib-406/bytes.cmj stdlib-406/stringLabels.cmi $bsc others
o stdlib-406/stringLabels.cmj : cc_cmi stdlib-406/stringLabels.res | stdlib-406/array.cmj stdlib-406/bytes.cmj stdlib-406/stringLabels.cmi $bsc others
o stdlib-406/stringLabels.cmi : cc stdlib-406/stringLabels.resi | stdlib-406/pervasives.cmj $bsc others
o stdlib-406/sys.cmj : cc_cmi stdlib-406/sys.res | stdlib-406/sys.cmi $bsc others
o stdlib-406/sys.cmi : cc stdlib-406/sys.resi | stdlib-406/pervasives.cmj $bsc others
Expand Down
2 changes: 1 addition & 1 deletion jscomp/stdlib-406/string.res
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ let blit = B.blit_string

%%private(@send external join: (array<string>, string) => string = "join")

let concat = (sep: string, xs: list<string>) => xs->Belt_List.toArray->join(sep)
let concat = (sep: string, xs: list<string>) => xs->Array.of_list->join(sep)

/* duplicated in bytes.ml */
let iter = (f, s) =>
Expand Down
2 changes: 1 addition & 1 deletion jscomp/stdlib-406/stringLabels.res
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ let blit = (~src, ~src_pos, ~dst, ~dst_pos, ~len) => B.blit_string(src, src_pos,

%%private(@send external join: (array<string>, string) => string = "join")

let concat = (~sep: string, xs: list<string>) => xs->Belt_List.toArray->join(sep)
let concat = (~sep: string, xs: list<string>) => xs->Array.of_list->join(sep)

/* duplicated in bytes.ml */
let iter = (~f, s) =>
Expand Down
8 changes: 4 additions & 4 deletions jscomp/test/ext_filename_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions jscomp/test/string_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions lib/es6/string.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@


import * as Caml from "./caml.js";
import * as $$Array from "./array.js";
import * as Bytes from "./bytes.js";
import * as Curry from "./curry.js";
import * as Belt_List from "./belt_List.js";
import * as Caml_string from "./caml_string.js";
import * as Caml_js_exceptions from "./caml_js_exceptions.js";

Expand All @@ -16,7 +16,7 @@ function sub(s, ofs, len) {
}

function concat(sep, xs) {
return Belt_List.toArray(xs).join(sep);
return $$Array.of_list(xs).join(sep);
}

function iter(f, s) {
Expand Down
4 changes: 2 additions & 2 deletions lib/es6/stringLabels.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@


import * as Caml from "./caml.js";
import * as $$Array from "./array.js";
import * as Bytes from "./bytes.js";
import * as Curry from "./curry.js";
import * as Belt_List from "./belt_List.js";
import * as Caml_string from "./caml_string.js";
import * as Caml_js_exceptions from "./caml_js_exceptions.js";

Expand All @@ -18,7 +18,7 @@ function sub(s, ofs, len) {
var blit = Bytes.blit_string;

function concat(sep, xs) {
return Belt_List.toArray(xs).join(sep);
return $$Array.of_list(xs).join(sep);
}

function iter(f, s) {
Expand Down
4 changes: 2 additions & 2 deletions lib/js/string.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict';

var Caml = require("./caml.js");
var $$Array = require("./array.js");
var Bytes = require("./bytes.js");
var Curry = require("./curry.js");
var Belt_List = require("./belt_List.js");
var Caml_string = require("./caml_string.js");
var Caml_js_exceptions = require("./caml_js_exceptions.js");

Expand All @@ -16,7 +16,7 @@ function sub(s, ofs, len) {
}

function concat(sep, xs) {
return Belt_List.toArray(xs).join(sep);
return $$Array.of_list(xs).join(sep);
}

function iter(f, s) {
Expand Down
4 changes: 2 additions & 2 deletions lib/js/stringLabels.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict';

var Caml = require("./caml.js");
var $$Array = require("./array.js");
var Bytes = require("./bytes.js");
var Curry = require("./curry.js");
var Belt_List = require("./belt_List.js");
var Caml_string = require("./caml_string.js");
var Caml_js_exceptions = require("./caml_js_exceptions.js");

Expand All @@ -18,7 +18,7 @@ function sub(s, ofs, len) {
var blit = Bytes.blit_string;

function concat(sep, xs) {
return Belt_List.toArray(xs).join(sep);
return $$Array.of_list(xs).join(sep);
}

function iter(f, s) {
Expand Down