Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forwardRef in uncurried mode #6447

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Fix forwardRef in uncurried mode #6447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73f6578
fix forwardRef in uncurried mode
mununki Oct 22, 2023
3531736
changelog
mununki Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- Fix issue where GenType was not supporting `@tag` on ordinary variatns https://github.com/rescript-lang/rescript-compiler/pull/6437
- Fix using dynamic import of module in block instead of async function https://github.com/rescript-lang/rescript-compiler/pull/6434
- Fix issue with using dynamic import of module in uncurried mode https://github.com/rescript-lang/rescript-compiler/pull/6434
- Fix build error where JSX v4 transformation of the discouraged forwardRef in uncurried mode https://github.com/rescript-lang/rescript-compiler/pull/6447

#### :nail_care: Polish

Expand Down
3 changes: 2 additions & 1 deletion jscomp/syntax/src/reactjs_jsx_v4.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,8 @@ let mapBinding ~config ~emptyLoc ~pstr_loc ~fileName ~recFlag binding =
let fullExpression =
if !Config.uncurried = Uncurried then
fullExpression
|> Ast_uncurried.uncurriedFun ~loc:fullExpression.pexp_loc ~arity:1
|> Ast_uncurried.uncurriedFun ~loc:fullExpression.pexp_loc
~arity:(if hasForwardRef then 2 else 1)
else fullExpression
in
let fullExpression =
Expand Down