Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowing using dyanmic import of module instead of async function #6434

Merged
merged 4 commits into from
Oct 17, 2023
+22 −3
Merged

Fix allowing using dyanmic import of module instead of async function #6434

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4386164
fix using await module instead of async function
mununki Oct 11, 2023
03501b2
changelog
mununki Oct 11, 2023
e4125ac
changelog
mununki Oct 11, 2023
a0c1f45
fix error dynamic import of module in uncurried
mununki Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix error dynamic import of module in uncurried
@mununki
mununki committed Oct 12, 2023
commit a0c1f45f0ee2aeb16aa032b6c792df17b584b21d
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -14,9 +14,10 @@

#### :bug: Bug Fix

- Fix issue with Dynamic import of module in nested expressions https://github.com/rescript-lang/rescript-compiler/pull/6431
- Fix issue with dynamic import of module in nested expressions https://github.com/rescript-lang/rescript-compiler/pull/6431
- Fix issue where GenType was not supporting `@tag` on ordinary variatns https://github.com/rescript-lang/rescript-compiler/pull/6437
- Fix using dynamic import of module in block instead of async function https://github.com/rescript-lang/rescript-compiler/pull/6434
- Fix issue with using dynamic import of module in uncurried mode https://github.com/rescript-lang/rescript-compiler/pull/6434

#### :nail_care: Polish

1 change: 1 addition & 0 deletions jscomp/frontend/bs_builtin_ppx.ml
View file
Original file line number Diff line number Diff line change
@@ -620,6 +620,7 @@ let rec structure_mapper ~await_context (self : mapper) (stru : Ast_structure.t)
| Pexp_let (_, vbs, expr) -> aux expr @ spelunk_vbs acc vbs
| Pexp_ifthenelse (_, then_expr, Some else_expr) ->
aux then_expr @ aux else_expr
| Pexp_construct (_, Some expr) -> aux expr
| Pexp_fun (_, _, _, expr) | Pexp_newtype (_, expr) -> aux expr
| _ -> acc
in