Fix build error with Dynamic import of module in nested expressions #6431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZakh
reviewed
Oct 10, 2023
CHANGELOG.md
Outdated
| @@ -33,6 +33,7 @@ | |||
|
|
|||
| - Fix issue with GenType and labelled arguments. https://github.com/rescript-lang/rescript-compiler/pull/6406 | |||
| - Fix dependencies reinitialization on every change in watch mode. Leads to faster rebuilds and cleaner terminal. https://github.com/rescript-lang/rescript-compiler/pull/6404 | |||
| - Fix issue with Dynamic import of module in nested expressions https://github.com/rescript-lang/rescript-compiler/pull/6431 | |||
There was a problem hiding this comment.
I think it should be in rc.5
There was a problem hiding this comment.
Good catch.
After this PR #6427 merged, then I'll rebase this PR and move it to rc.5.
There was a problem hiding this comment.
@cknitt What do you think?
There was a problem hiding this comment.
Yes, rc.5 please, as rc.4 is out already.
mununki
force-pushed
the
nested-import-module
branch
from
4b7d77b to
8dbb0f8
Compare
cknitt
approved these changes
Oct 11, 2023
|
Merge? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6430
This PR modifies dynamic import of module to be a transformation even when used in nested expressions (let-in). Adds handling for the following cases: