Improve error message for duplicate labels #6415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @DZakh |
DZakh
reviewed
Sep 27, 2023
Comment on lines
+2001
to
+2004
| | Duplicate_label (s, None) -> | ||
| fprintf ppf "The field @{<info>%s@} is defined several times in this record. Fields can only be added once to a record." s | ||
| | Duplicate_label (s, Some recordName) -> | ||
| fprintf ppf "The field @{<info>%s@} is defined several times in the record @{<info>%s@}. Fields can only be added once to a record." s recordName |
There was a problem hiding this comment.
I suppose the error message might be used for objects as well.
There was a problem hiding this comment.
Objects are a bit trickier, and needs a general overhaul. Doesn't seem like overwriting object fields is an error at all, although you can't change their type of course.
cristianoc
approved these changes
Sep 27, 2023
cristianoc
reviewed
Sep 27, 2023
| @@ -1998,8 +1998,10 @@ let report_error ppf = function | |||
| fprintf ppf "A type parameter occurs several times" | |||
| | Duplicate_constructor s -> | |||
| fprintf ppf "Two constructors are named %s" s | |||
| | Duplicate_label s -> | |||
| fprintf ppf "Two labels are named %s" s | |||
| | Duplicate_label (s, None) -> | |||
There was a problem hiding this comment.
Curious: when does this case fire?
There was a problem hiding this comment.
Inline records, I believe.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.