Skip to content

Error messages: Improve "Somewhere wanted" messages #6410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 26, 2023
Merged

Error messages: Improve "Somewhere wanted" messages #6410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9fd8f52
first batch of changes trying to improve the Somewhere wanted error m…
zth Sep 20, 2023
b7efb12
tweaks
zth Sep 21, 2023
79c827f
add more fixtures
zth Sep 21, 2023
b2ffe93
remove redundant text
zth Sep 21, 2023
3db8179
add specialized errors for array items and setting record fields
zth Sep 21, 2023
a412502
tweak set record field message
zth Sep 22, 2023
873e2d3
hint about tuple in array message
zth Sep 24, 2023
c28e011
move message handling to own file
zth Sep 24, 2023
89ba484
cleanup
zth Sep 24, 2023
0a35136
cleanup
zth Sep 24, 2023
a878602
cleanup
zth Sep 24, 2023
99bbf9f
cleanup
zth Sep 24, 2023
f85fdc4
changelog
zth Sep 24, 2023
cd464f2
add example of tuple to error message
zth Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak set record field message
  • Loading branch information
@zth
zth committed Sep 22, 2023
commit a412502aa9eb4e1e560b39384e28419baf8a778f
2 changes: 1 addition & 1 deletion jscomp/build_tests/super_errors/expected/set_record_field_type_match.res.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
11 │ user.name = 12
12 │

This has type: int
You're assigning something to this field that has type: int
But this record field is of type: string

You can convert int to string with Belt.Int.toString.
1 change: 1 addition & 0 deletions jscomp/ml/typecore.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,7 @@ let print_expr_type_clash ?typeClashContext env trace ppf = begin
| Some (Statement(FunctionCall)) -> "This function call returns:"
| Some (MathOperator{isConstant=Some _}) -> "This value has type:"
| Some (ArrayValue) -> "This array item has type:"
| Some SetRecordField -> "You're assigning something to this field that has type:"
| _ -> "This has type:"
) in
fprintf ppf "%s" text)
Expand Down