Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async component for React Server component in JSX v4 #6399

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Support async component for React Server component in JSX v4 #6399

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2fc6d8f
add tests
mununki Sep 12, 2023
38239bc
support async in JSX ppx
mununki Sep 12, 2023
2c90fb4
update changelog
mununki Sep 12, 2023
efed71f
convert async component type
mununki Sep 12, 2023
8fbaee4
eof
mununki Sep 12, 2023
a0402ae
use asyncComponent func
mununki Sep 12, 2023
e896491
fix polymorphic type inference
mununki Oct 1, 2023
8126a13
remove duplicated function
mununki Oct 3, 2023
4d1e792
relocate ast_await into ml
mununki Oct 3, 2023
9d283ba
remove duplicated is_async function
mununki Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add tests
  • Loading branch information
@mununki
mununki committed Oct 1, 2023
commit 2fc6d8f8e30c694673b51a187772242d11f3427c
7 changes: 7 additions & 0 deletions jscomp/syntax/tests/ppx/react/asyncAwait.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
let f = a => Js.Promise.resolve(a + a)

@react.component
let make = async (~a) => {
let a = await f(a)
<div> {React.int(a)} </div>
}
12 changes: 12 additions & 0 deletions jscomp/syntax/tests/ppx/react/expected/asyncAwait.res.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
let f = a => Js.Promise.resolve(a + a)
type props<'a> = {a: 'a}

let make = ({a, _}: props<_>) => {
let a = await f(a)
ReactDOM.jsx("div", {children: ?ReactDOM.someElement({React.int(a)})})
}
let make = {
let \"AsyncAwait" = (props: props<_>) => make(props)

\"AsyncAwait"
}