Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keys mangling for gentype #6359

Merged

Conversation

DZakh
Copy link
Contributor

@DZakh DZakh commented Aug 19, 2023

There's also this file with the same code as in Runtime.ml:
rescript-compiler/jscomp/syntax/tests/idempotency/genType/src/Runtime.res
I couldn't figure out what to do with it.

Related to: #6354

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking:
I guess you did make gentype test
And run npx run tsc on the artefacts to check that TS does not complain.

@DZakh
Copy link
Contributor Author

DZakh commented Aug 19, 2023

Not npx run tsc :)

@cknitt
Copy link
Member

cknitt commented Aug 20, 2023

Sorry, it seems I caused some conflicts by merging #6358.

@DZakh DZakh force-pushed the remove-keys-mangling-for-gentype branch from 8a7664b to ffeab58 Compare August 20, 2023 08:47
@DZakh
Copy link
Contributor Author

DZakh commented Aug 20, 2023

Sorry, it seems I caused some conflicts by merging #6358.

No problem, I've seen the changes, so I expected a merge conflict.

rescript-compiler/jscomp/syntax/tests/idempotency/genType/src/Runtime.res

Still don't understand what to do with it 👆

@cristianoc
Copy link
Collaborator

Sorry, it seems I caused some conflicts by merging #6358.

No problem, I've seen the changes, so I expected a merge conflict.

rescript-compiler/jscomp/syntax/tests/idempotency/genType/src/Runtime.res

Still don't understand what to do with it 👆

It's just a test, ignore it. Used to test the parser.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsc is happy -- good to go

@cristianoc cristianoc merged commit 835a961 into rescript-lang:master Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants