Fix shadowing Js.Json.t with type kind #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
approved these changes
Jul 3, 2023
cristianoc
reviewed
Jul 3, 2023
jscomp/others/js_json.res
Outdated
| | Boolean: kind<bool> | ||
| | Null: kind<Js_types.null_val> | ||
| module Kind = { | ||
| type rec kind<_> = |
CHANGELOG.md
Outdated
| @@ -14,6 +14,9 @@ | |||
| #### :rocket: New Feature | |||
| - Variants: Allow coercing from variant to variant, where applicable. https://github.com/rescript-lang/rescript-compiler/pull/6314 | |||
|
|
|||
| #### :boom: Breaking Change | |||
| - Fixed Js.Json.kind type shadowing Js.Json.t type: `type kind<_>` -> `type Kind.kind<_>` https://github.com/rescript-lang/rescript-compiler/pull/6317 | |||
There was a problem hiding this comment.
This should say what the breaking change is and what is the fix for someone relying on the previous behaviour.
cristianoc
reviewed
Jul 3, 2023
jscomp/others/js_json.res
Outdated
| | Boolean: kind<bool> | ||
| | Null: kind<Js_types.null_val> | ||
| module Kind = { | ||
| type rec s<_> = |
There was a problem hiding this comment.
Not sure I understand your notation, but
s / kind / t 695bb47
This reverts commit 7a8880b.
cristianoc
reviewed
Jul 4, 2023
CHANGELOG.md
Outdated
| @@ -14,6 +14,9 @@ | |||
| #### :rocket: New Feature | |||
| - Variants: Allow coercing from variant to variant, where applicable. https://github.com/rescript-lang/rescript-compiler/pull/6314 | |||
|
|
|||
| #### :boom: Breaking Change | |||
| - Fixed the issue of name collision between the newly defined Js.Json.t and the variant constructor in the existing Js.Json.kind type. To address this, the usage of the existing Js.Json.kind type can be updated to Js.Json.Kind.s. https://github.com/rescript-lang/rescript-compiler/pull/6317 | |||
There was a problem hiding this comment.
Can you explain why it's not t?
There was a problem hiding this comment.
I thought it's idiomatic for types
There was a problem hiding this comment.
It ended up being t, s was just a confusion.
There was a problem hiding this comment.
It is t.
type t
module Kind = {
type json = t
type t
}
cristianoc
approved these changes
Jul 4, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with existing Js.Json.kind types shadowing the variant constructor of Js.Json.t types.