Example of complex pattern for untagged variant.

[cristianoc]

From #6108

[cristianoc]

@zth see examples of simplifications in the various commits.

Some things to think about:

• how much simpler is the overall function?
• how ad-hoc are these simplifications?
• one needs to cast a wider net beyond booleans, and consider more cases of pattern matching.

Basically, the question is of return on investment. What do you think?

[zth]

Nice!

[zth]

These are good questions. I'd say it looks quite a lot simpler. But, I don't have good answers for the rest of the questions... Is this type of optimization very specific to just these cases?

[cristianoc]

asking our friend

Pros:

1. Code simplification: The PR significantly simplifies the generated JavaScript code, making it easier to read and understand, as well as potentially improving performance.
2. Better pattern matching: The PR improves the pattern matching, potentially leading to more efficient code execution and a better developer experience.
3. Incremental improvements: Proceeding with this PR is a step towards optimizing the compiler further, paving the way for future enhancements and optimizations.

Cons:

1. Ad-hoc nature: The simplifications made in this PR might be too specific to the given test case and not applicable to a broader range of cases, which might limit the overall impact of the optimizations.
2. Maintenance burden: The PR adds new code that needs to be maintained, which could increase the complexity of the compiler codebase and make future modifications more difficult.
3. Unexplored cases: There might be other, more general optimizations that could be applied to the compiler. Proceeding with this PR might divert focus from discovering and implementing these more general solutions.

[cristianoc]

How about exploring more cases next? Can you give me another example that falls outside what this PR does? E.g. not only booleans.
Also, is the example code OK now or is there something else to optimise?

[zth]

Coming back to this soon.

[zth]

Haven't been able to figure out a good other example. This does feel like a nice improvement as is. What about merging this and then continuing with more examples later on?