Move Jsx and JsxDOM inside Pervasives. #6091
Merged
+5,742
−4,402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
move_jsx_jsxdom
branch
from
b0e53d7 to
de4111e
Compare
cristianoc
force-pushed
the
move_jsx_jsxdom
branch
3 times, most recently
from
1d42992 to
9ce5930
Compare
cristianoc
added a commit
to rescript-lang/rescript-vscode
that referenced
this pull request
Mar 22, 2023
See rescript-lang/rescript#6091 where the jsx modules are moved inside Pervasives, to provide 2 different copies for curried and uncurried mode.
cristianoc
force-pushed
the
move_jsx_jsxdom
branch
3 times, most recently
from
ac771c6 to
2fc209d
Compare
Turn JsxDOM into a module, so it's built separately for Pervasives and PervasivesU.
cristianoc
force-pushed
the
move_jsx_jsxdom
branch
from
2fc209d to
2f1745f
Compare
cknitt
approved these changes
Mar 22, 2023
cristianoc
added a commit
to rescript-lang/rescript-vscode
that referenced
this pull request
Mar 22, 2023
See rescript-lang/rescript#6091 where the jsx modules are moved inside Pervasives, to provide 2 different copies for curried and uncurried mode.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn JsxDOM into a module, so it's built separately for Pervasives and PervasivesU.