Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error if the lib dir is included in the sources #5966

Merged
merged 1 commit into from
Feb 6, 2023
Merged

add error if the lib dir is included in the sources #5966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jscomp/bsb/bsb_parse_sources.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ and parsing_single_source ({ package_kind; is_dev; cwd } as cxt)
let dir =
match map.?(Bsb_build_schemas.dir) with
| Some (Str { str }) ->
if str = Literals.library_file then
Bsb_exception.config_error x (Printf.sprintf "dir field should be different from `%s`" Literals.library_file)
else
Ext_path.simple_convert_node_path_to_os_path str
| Some x ->
Bsb_exception.config_error x "dir expected to be a string"
Expand Down