Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare bin_path logic for more platforms/architectures #5932

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jan 7, 2023

If we want to include binaries for additional platforms/architectures in the npm package (Linux arm64 would be the next candidate), we need to think about the bin path / directory name for those.

Currently we are supporting the following architectures:

  • x64: darwin, linux, windows
  • arm64: darwin

and we have some special logic in place to use "darwinarm64" for darwin on arm64.

To generalize while keeping compatible with the existing naming, we can use the following rule:

  • For architecture x64, the directory name is just the platform name.
  • For all other architectures, it is platform name + architecture name.

@cknitt cknitt marked this pull request as ready for review January 7, 2023 16:08
@cknitt cknitt requested review from cristianoc and ryyppy January 7, 2023 16:08
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's backwards compatible it should be safe.

@cknitt cknitt merged commit a6d3a7c into rescript-lang:master Jan 7, 2023
@cknitt cknitt deleted the bin-path-more-archs branch January 7, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants