Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest syntax #5762

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Latest syntax #5762

merged 1 commit into from
Oct 29, 2022

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc changed the base branch from master to 10.1_release October 29, 2022 05:05
@cristianoc cristianoc mentioned this pull request Oct 29, 2022
@cristianoc cristianoc requested a review from mununki October 29, 2022 05:07
@cristianoc
Copy link
Collaborator Author

@mattdamon108 is there anything pending for another 10.1 release?
CC @cknitt

@mununki
Copy link
Member

mununki commented Oct 29, 2022

@mattdamon108 is there anything pending for another 10.1 release? CC @cknitt

I have nothing in my hand for 10.1 now.

@cristianoc cristianoc merged commit 70cb393 into 10.1_release Oct 29, 2022
@cristianoc cristianoc deleted the latest_syntax branch October 29, 2022 05:11
Copy link
Member

@mununki mununki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very excited about releasing 10.1

@cknitt
Copy link
Member

cknitt commented Oct 29, 2022

@mattdamon108 I am excited, too! 😃

What is still open is rescript-lang/syntax#686. The current behavior is quite unintuitive, and other people have stumbled upon it too while testing the release, see cristianoc/rescript-compiler-experiments#1 (comment).

Not sure how easy this is to resolve and if it should better be tackled in a 10.1.1 or something.

@cristianoc
Copy link
Collaborator Author

@mattdamon108 I am excited, too! 😃

What is still open is rescript-lang/syntax#686. The current behavior is quite unintuitive, and other people have stumbled upon it too while testing the release, see cristianoc/rescript-compiler-experiments#1 (comment).

Not sure how easy this is to resolve and if it should better be tackled in a 10.1.1 or something.

Either way is possible. In any case one more round of testing is required to check there are no unknown issues left (or newly introduced).

@d4h0
Copy link
Contributor

d4h0 commented Oct 29, 2022

What is still open is rescript-lang/syntax#686. The current behavior is quite unintuitive

As excited as I am for async/await finally landing in ReScript, I 100 % agree with that. I'm pretty sure that a significant amount of people will stumble upon this.

It would be better to wait a few additional days/weeks until that issue is solved.

@cristianoc
Copy link
Collaborator Author

Periodic reminder that the issue is about pipe not async/await per se and likely that the change will be a breaking change for pipe.
Just so all elements are considered.

@cristianoc
Copy link
Collaborator Author

It's one more reason to go find out. Just, the outcome is not completely clear at this stage.

@cknitt
Copy link
Member

cknitt commented Oct 29, 2022

I think this should also be resolved before the 10.1 release: rescript-lang/rescript-vscode#617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants