Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove odoc_gen. #5689

Merged
merged 3 commits into from
Sep 24, 2022
Merged

Remove odoc_gen. #5689

merged 3 commits into from
Sep 24, 2022

Conversation

cristianoc
Copy link
Collaborator

This does not seem to be used anymore.

@cristianoc cristianoc requested a review from cknitt September 24, 2022 04:14
@cristianoc
artifacts
28f0597
@cristianoc
Locally building the list of artifacts does not really work.
6ec747c 
There are all these executables missing, and the ninja.COPYING things only happens in CI.
@cristianoc
Copy link
Collaborator Author

@cknitt I think the instructions for artifacts in CONTRIBUTING.md are stale.
It seems the me the way to go currently is to wait for CI to fail then manually edit the file.

cknitt
cknitt approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! With the platform bin dirs gone from the repo too after #5683, the project root will start to look quite clean. 🙂

@cknitt
Copy link
Member

cknitt commented Sep 24, 2022

@cknitt I think the instructions for artifacts in CONTRIBUTING.md are stale. It seems the me the way to go currently is to wait for CI to fail then manually edit the file.

The instructions are still correct, but ninja.exe will need to be added to makeArtifactList.js as an exe to be assumed present for all platforms. Will do that.

@cristianoc cristianoc merged commit 6ca4cba into master Sep 24, 2022
@cristianoc cristianoc deleted the odoc_gen branch September 24, 2022 06:35
@cknitt cknitt mentioned this pull request Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianoc @cknitt