-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placeholder types for ES6 collections #5630
Add placeholder types for ES6 collections #5630
Conversation
I'm not very sure why CI is failing as |
Touching |
I vaguely remember something about a duplicate module (file) that was kept in sync manually + non-deterministic build order. |
thanks, it looks like I had to edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of typos in comments.
Would you update the changelog too? |
I'm not sure which tag to use for this. Is this a "New Feature" or "Internal"? |
It think new feature as it's user visible. |
Related: #5282
This PR adds placeholder types for ES6 collection types: Set, Map, WeakSet, and WeakMap.