Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder types for ES6 collections #5630

Merged

Conversation

cannorin
Copy link
Contributor

@cannorin cannorin commented Sep 1, 2022

Related: #5282

This PR adds placeholder types for ES6 collection types: Set, Map, WeakSet, and WeakMap.

@cannorin
Copy link
Contributor Author

cannorin commented Sep 1, 2022

I'm not very sure why CI is failing as opam exec -- npm ci does not fail on my PC. @cristianoc could you help?

@cristianoc
Copy link
Collaborator

Touching Js often creates more trouble than it is legitimate to expect, for no apparent reason.
Probably something set up wrongly in the build or race condition.
I vaguely remember @cknitt sorting out a similar issue?

@cknitt
Copy link
Member

cknitt commented Sep 1, 2022

I vaguely remember something about a duplicate module (file) that was kept in sync manually + non-deterministic build order.

@cannorin
Copy link
Contributor Author

cannorin commented Sep 1, 2022

thanks, it looks like I had to edit jscomp/runtime/js.ml too 😄

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos in comments.

@cristianoc
Copy link
Collaborator

Would you update the changelog too?

@cannorin
Copy link
Contributor Author

cannorin commented Sep 1, 2022

I'm not sure which tag to use for this. Is this a "New Feature" or "Internal"?

@cristianoc
Copy link
Collaborator

I'm not sure which tag to use for this. Is this a "New Feature" or "Internal"?

It think new feature as it's user visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants