Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build lock not releasing #5591

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

TheSpyder
Copy link
Contributor

I tried a few different ways to fix this, but in the end just moving the watch mode exit handlers out to run all the time was the best approach.

Fixes #5590.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thought on why moving them was necessary?
Not familiar with this code, so asking basic questions.

@TheSpyder
Copy link
Contributor Author

If you expand the diff a bit, previously the listeners were inside a function that only runs in watch mode.

Now they are set up before deciding what to do based on the arguments.

@cristianoc
Copy link
Collaborator

Makes perfect sense.
Thanks for the fix!

@cristianoc cristianoc merged commit 3babb58 into rescript-lang:master Jul 24, 2022
@TheSpyder TheSpyder deleted the lockfile_cleanup branch July 24, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v10 compiler lock file no longer cleaned up after SIGINT
2 participants