Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: build @rescript/std, too #5491

Merged
merged 1 commit into from
Jun 30, 2022
Merged

CI: build @rescript/std, too #5491

merged 1 commit into from
Jun 30, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jun 30, 2022 •
edited
Loading

The npm package for the external stdlib is currently maintained in a separate repo https://github.com/rescript-lang/std that needs to be synced manually.

This PR obviates the need for that repo and the manual syncing. CI now builds both the rescript and the @rescript/std packages.

@cknitt cknitt force-pushed the ci-stdlib branch 2 times, most recently from 9fec08a to 044602d Compare June 30, 2022 15:21
@cknitt cknitt marked this pull request as ready for review June 30, 2022 17:03
@cknitt cknitt requested a review from cristianoc June 30, 2022 17:03
cristianoc
cristianoc approved these changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch.

@cknitt cknitt merged commit bde2435 into rescript-lang:master Jun 30, 2022
@cknitt cknitt deleted the ci-stdlib branch June 30, 2022 18:49
mununki pushed a commit to mununki/rescript-compiler that referenced this pull request Jul 15, 2022
@cknitt @mununki
CI: build @rescript/std, too (rescript-lang#5491)
4d0088b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @cristianoc