Prevent non-terminating build #5485
Conversation
using generatedFileExtension in gentypeconfig
rescript
Outdated
| @@ -28,6 +28,8 @@ var lockFileName = path.join(cwd, ".bsb.lock"); | |||
| process.env.BSB_PROJECT_ROOT = cwd; | |||
| // console.log('BSB_PROJECT_ROOT:', process.env.BSB_PROJECT_ROOT) | |||
|
|
|||
| var generatedFileExtension = require(path.join(cwd, "bsconfig.json")).gentypeconfig.generatedFileExtension; | |||
There was a problem hiding this comment.
What if gentypeconfig does not exist?
There was a problem hiding this comment.
It is undefined, and fileName.endsWith(undefined) evaluates to false. I can add a guard and provide a default value, e.g., .gen.tsx, if this seems too dangerous, though.
There was a problem hiding this comment.
It's actually going to crash if gentypeconfig is not specified in bsconfig.json.
There was a problem hiding this comment.
This is my bad. I'll fix it.
There was a problem hiding this comment.
Would you also rename it? Should indicate it's for gentype.
|
@cristianoc Yes, I did reproduce and verified that it did fix the error. I personally suffered from this issue and found the issue mentioned above from searching. I'm currently not in front of the computer, and I'll resolve the issues mentioned above when I get back. I'm sorry for the inconvenience! |
|
Thanks a lot for doing the fix! |
|
Yes, it does work for bsconfig.json with or without gentypeconfig, and with or without generatedFileExtension. |
using generatedFileExtension in gentypeconfig
This can fix non-terminating build due to custom generated file extensions (#5303).