Sync docs for js_re.ml #5443
Merged
Sync docs for js_re.ml #5443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryyppy
approved these changes
Jun 18, 2022
| Provides bindings for JavaScript Regular Expressions | ||
|
|
||
| {4 Syntax sugar} | ||
| ReScript provides a bit of syntax sugar for regex literals: `[%re "/foo/g"]` |
There was a problem hiding this comment.
I guess this part was removed since there is already some coverage in the manual: https://rescript-lang.org/docs/manual/latest/primitive-types#regular-expression
I guess it would generally be better to document the details in the manual instead to make the information more visible?
There was a problem hiding this comment.
I see your point. Agree, the intro is better suited for the manual.
So, I’d just live here the note telling the API is not immutable.
nkrkv
force-pushed
the
sync-belt-doc-headers-js-re
branch
from
f7dbc97 to
634b6b9
Compare
|
Yep. I’ve recovered a few links to MDN. Now I consider the PR is ready for merge. |
|
looking good. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case where MDX is arguably inferior to the comments. Please, review the content removed: