Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync docs for Belt Map, Map.Dict, Map.Int, Map.String, MutableMap, MutableMap.Int, MutableMap.String #5429

Merged

Conversation

Minnozz
Copy link
Contributor

@Minnozz Minnozz commented Jun 11, 2022

  • belt_Map.mli
  • belt_MapDict.mli
  • belt_MapInt.mli
  • belt_MapString.mli
  • belt_MutableMap.mli
  • belt_MutableMapInt.mli
  • belt_MutableMapString.mli

@Minnozz Minnozz mentioned this pull request Jun 11, 2022
35 tasks
@Minnozz Minnozz force-pushed the sync-belt-doc-headers-map branch from f3c9da6 to 57d2587 Compare June 11, 2022 19:34
@Minnozz Minnozz changed the title WIP: Sync docs for belt_Map.mli Sync docs for belt_Map.mli Jun 11, 2022
@Minnozz Minnozz marked this pull request as ready for review June 11, 2022 19:36
@Minnozz
Copy link
Contributor Author

Minnozz commented Jun 11, 2022

@ryyppy Ready for review

@Minnozz Minnozz marked this pull request as draft June 12, 2022 11:49
@Minnozz
Copy link
Contributor Author

Minnozz commented Jun 12, 2022

I'll continue with the other Map modules in the same PR.

@Minnozz Minnozz changed the title Sync docs for belt_Map.mli Sync docs for Belt Map, Map.Dict, Map.Int, Map.String, MutableMap, MutableMap.Int, MutableMap.String Jun 12, 2022
@Minnozz Minnozz marked this pull request as ready for review June 12, 2022 15:42
@Minnozz Minnozz force-pushed the sync-belt-doc-headers-map branch from 46468f9 to 7ff3515 Compare June 13, 2022 12:51
@Minnozz Minnozz force-pushed the sync-belt-doc-headers-map branch from 7ff3515 to 30dc28d Compare June 13, 2022 12:57
@Minnozz Minnozz requested a review from ryyppy June 13, 2022 12:58
@ryyppy
Copy link
Member

ryyppy commented Jun 14, 2022

looking good. thanks!

@ryyppy ryyppy merged commit 2800a93 into rescript-lang:sync-belt-doc-headers Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants