Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements over incremental build #4747

Merged
merged 10 commits into from
Oct 14, 2020
Merged

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Oct 14, 2020

a bunch of improvment including:

  • no unneeded rebuild for cmi when changing package specs

  • better postbuild support, (built in $out_last support)

previously for each target, the postbuild command has to be repeated, we introduced $out_last to remove such duplication
old

rule mij
  command = $bsc $g_pkg_flg -bs-package-output commonjs:lib/js/$in_d:.js $g_lib_incls $warnings $bsc_flags -o $out $in $postbuild
  dyndep = $in_e.d
  restat = 1
o src/demo.cmj | src/demo.cmi ../js/src/demo.js : mij src/demo.mlast || src/demo.d
   postbuild = && cat ../js/src/demo.js
rule mij
  command = $bsc $g_pkg_flg -bs-package-output commonjs:lib/js/$in_d:.js $g_lib_incls $warnings $bsc_flags -o $out $in && cat $out_last
  dyndep = $in_e.d
  restat = 1
o src/demo.cmj | src/demo.cmi ../js/src/demo.js : mij src/demo.mlast || src/demo.d
  • some micro-tweaks

TODO: rule variables are expanded when used, if we don't use the dynamism we should interoplate directly

@bobzhang bobzhang merged commit 6fd866c into master Oct 14, 2020
@cristianoc cristianoc deleted the no_package_name_in_cmi branch June 18, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant