Add a lazy bsb_global_backend and use it everywhere #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobzhang
reviewed
Feb 1, 2020
|
|
||
| val backend : Bsb_config_types.compilation_kind_t Lazy.t | ||
|
|
||
| val lib_artifacts_dir : string Lazy.t |
There was a problem hiding this comment.
from what I can tell lib_artifacts_dir is used a lot.
Where is backend and cmdline_backend used?
There was a problem hiding this comment.
Oh they are both used by the full native PR, but not in this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds bsb_global_backend, useful for native compilation. This shouldn't change any behavior and should be fairly fast thanks to
Lazy. This will allow us to have the JS artifacts stay inlib/bsand then have the native artifacts inlib/nativeand bytecode inlib/bytecode.You should merge #4086 first.