Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch symlinked packages dirs #4047

Closed
wants to merge 7 commits into from
Closed

Watch symlinked packages dirs #4047

wants to merge 7 commits into from
+44 −8

Conversation

Coobaha
Copy link
Contributor

@Coobaha Coobaha commented Dec 15, 2019 •
edited
Loading

Adds getDirsForRelativeSymlinkedPackages that checks if package is a symbolic link. If yes it adds all dirs from package and it's dependencies to watched list. Works only with bsb -w -make-world

Resolves #3521

Requires recursive .sourcedirs.json #4043

@Coobaha Coobaha mentioned this pull request Dec 15, 2019
Closed
@Coobaha
remote relative cwd check and add -make-world to rebuild arguments
07f958f
@Coobaha
use delegate_args for rebuild args
f8e233d
@Coobaha
use watch_mode_delegate_args for rebuild args
115bd27
@Coobaha
use setImmediate for rebuilding in on_change callback
01938df 
Some editors are using temporary files to store edits. This results in two sync change events: change + rename and two sync builds. Using setImmediate will ensure that only one build done.
@Coobaha
add comment about setImmediate usage reason
dca0bb1
@Coobaha
cleanup
cc13e07
bobzhang
bobzhang reviewed Dec 16, 2019
View reviewed changes
@bobzhang
Copy link
Member

bobzhang commented Dec 20, 2019 •
edited
Loading

We will revisit the build system change after this release, since changes to build tool can easily introduce regression bugs, thanks for the contribution

@jchavarri
Copy link
Contributor

jchavarri commented Jan 3, 2020 •
edited
Loading

@bobzhang Is there any place or roadmap document where we could read about the build system changes that you mentioned? We (@ Ahrefs) are having a lot of trouble with symlinked packages when working locally and we are thinking on moving to a single bsconfig.json setup, but our problems would be solved with the fix in this PR.

@bobzhang
Copy link
Member

bobzhang commented Jan 7, 2020 •
edited
Loading

@jchavarri we will revisit this once we have rolled out 7.0.2

@baransu
Copy link

baransu commented Apr 28, 2020

I'm also at the point where I want to migrate to single bsconfig.json as having multiple problems with symlinked packages locally. This would solve the problem.

@BlueHotDog
Copy link

Joining in to the party. any update?

@BlueHotDog BlueHotDog mentioned this pull request May 8, 2020
Closed
@cristianoc
Copy link
Collaborator

Closing very old PRs.
Feel free to revive/reopen if there's still interest.

@cristianoc cristianoc closed this Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobzhang bobzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Make bsb watcher to also watch symlinks in node_modules
6 participants
@Coobaha @bobzhang @jchavarri @baransu @BlueHotDog @cristianoc