[Belt] Change ofArray to fromArray, and ofFoo to fromFoo in general #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed offline. Easier API to guess. Only changed the externally visible APIs. Didn't check in the JS files; too much noise for now.
bobzhang
reviewed
Mar 8, 2018
jscomp/others/belt_MapInt.ml
Outdated
| @@ -161,4 +161,5 @@ let getExn = I.getExn | |||
| let split = I.split | |||
| let mergeU = I.mergeU | |||
| let merge = I.merge | |||
| let fromArray = I.ofArray | |||
| let ofArray = I.ofArray | |||
There was a problem hiding this comment.
can you also change the internal I.ofArray into I.fromArray
jscomp/others/belt_MapString.ml
Outdated
| @@ -161,4 +161,5 @@ let getExn = I.getExn | |||
| let split = I.split | |||
| let mergeU = I.mergeU | |||
| let merge = I.merge | |||
| let fromArray = I.ofArray | |||
| let ofArray = I.ofArray | |||
There was a problem hiding this comment.
same, maybe a global regex replace should work
There was a problem hiding this comment.
Would accidentally grep the ofArray deprecation aliases & msgs if not careful, so I'm doing this semi-manually. Could have been a few clicks of merlin supported cross-file refactoring!
| @@ -155,9 +155,11 @@ let removeMany (type key) (type id) (d : _ t) xs = | |||
| (* let merge = I.merge *) | |||
|
|
|||
|
|
|||
| let ofArray xs = | |||
| let fromArray xs = | |||
| t ~data:(I.ofArray xs) | |||
|
see my comments, otherwise lgtm |
|
Guess I have to check in the JS artifacts after all, to make tests pass. I thought they were generated by CI on the fly but either Belt isn't or some of the tests aren't. Might create a few more conflicts while merging different diffs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed offline. Easier API to guess. Only changed the externally visible APIs.
Didn't check in the JS files; too much noise for now.