Only use 'use strict'; in amdjs and commonjs #2523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Restarted CI for you. It seems to have a problem with getting stuck these days |
bobzhang
reviewed
Feb 20, 2018
| let output_dir = Filename.dirname output_prefix in | ||
| P.string f L.strict_directive; | ||
| P.newline f ; | ||
| let output_dir = Filename.dirname output_prefix in |
There was a problem hiding this comment.
I am unclear how does this achieve the desired behavior?
There was a problem hiding this comment.
Instead of outputting it on all files it's just amd and commonjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES6 modules are always strict so
'use strict';unnecessary when using that as output. I'm not sure if this is a real problem as it will probably be removed by uglify or similar but that depends on if it is smart enough I guess.http://www.ecma-international.org/ecma-262/6.0/#sec-strict-mode-code
I'm kind of new to this (coming here via ReasonML) so any pointers on how to do this better are appreciated.