Skip to content

Spring cleaning: remove if-defs #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cristianoc opened this issue Apr 26, 2023 · 4 comments
Closed

Spring cleaning: remove if-defs #6205

cristianoc opened this issue Apr 26, 2023 · 4 comments
Assignees
Labels
stale Old issues that went stale
Milestone

Comments

@cristianoc
Copy link
Collaborator

The compiler codebase still has a few if-defs resolved during preprocessing.
A couple of consequences are:

  • cannot turn on reformatting for some of the codebase
  • cannot convert some (occasionally user-facing) files to .res
  • complicates the build

CC @ryyppy

@cristianoc cristianoc added this to the v12 milestone Apr 26, 2023
@cristianoc cristianoc changed the title Sprint cleaning: remove if-defs Spring cleaning: remove if-defs Apr 26, 2023
@ryyppy
Copy link
Member

ryyppy commented Apr 28, 2023

This would also include removing the .cppo files for e.g. belt, right?

@cristianoc
Copy link
Collaborator Author

Exactly right

@ryyppy
Copy link
Member

ryyppy commented May 3, 2023

Related #5458

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Old issues that went stale label Sep 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

3 participants