Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReScriptify cppo files for certain belt / Js modules #5458

Closed
ryyppy opened this issue Jun 22, 2022 · 5 comments
Closed

ReScriptify cppo files for certain belt / Js modules #5458

ryyppy opened this issue Jun 22, 2022 · 5 comments
Assignees

Comments

@ryyppy
Copy link
Member

ryyppy commented Jun 22, 2022

As stated in #5361 (rescriptify Belt / Js docs), we noticed that some modules are generated from cppo.ml[i] files.

That means that some docs will get overridden with the old docs as soon as we re-generate the necessary files. Therefore we either need to remove cppo from our user-facing modules infra, or accommodate cppo with ReScript code.

Goal is to be able to generate the relevant res and resi files for our Js and Belt modules.

Full list of cppo files with their generated counterparts:

  • map.cppo.ml[i] -> belt_Map*
  • mapm.cppo.ml[i] -> belt_MutableMap*
  • setm.cppo.ml[i] -> belt_MutableSet*
  • hashmap.cppo.ml[i] -> belt_HashMap*
  • belt_Set.cppo.ml[i] ->belt_Set*
  • js_typed_array.cppo.ml[i] ->js_typed_array
  • js_typed_array2.cppo.ml[i] ->js_typed_array2
  • sort.cppo.ml[i] ->belt_SortArray*
@cristianoc
Copy link
Collaborator

cppo does not actually parse files -- might run just as well on res files

@cristianoc
Copy link
Collaborator

ninja is instructed to only look for .ml and .mli files in jscomp/others but could look for .res and .resi

@cknitt
Copy link
Member

cknitt commented May 28, 2023

Started implementing this. Indeed it works fine to run cppo on .res files.

@cknitt cknitt self-assigned this May 28, 2023
@cknitt
Copy link
Member

cknitt commented May 28, 2023

See #6271 for the Belt part.

I will extend that to the rest of jscomp/other in a separate PR later.

@cknitt
Copy link
Member

cknitt commented Aug 25, 2024

Other cppo files were removed in #6283.

@cknitt cknitt closed this as completed Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants