Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rescript@11.0.0-alpha.3 broken formatting in uncurried mode for functions with _ placeholder args #6146

Closed
DZakh opened this issue Apr 14, 2023 · 3 comments
Closed

rescript@11.0.0-alpha.3 broken formatting in uncurried mode for functions with _ placeholder args #6146

DZakh opened this issue Apr 14, 2023 · 3 comments
Labels
bug
Milestone
v11.0

Comments

@DZakh
Copy link
Contributor

DZakh commented Apr 14, 2023

Input:

let concatStrings = (string1, string2) => string1 ++ string2
let toIgnoredName = concatStrings("_", _)

Expected:

let concatStrings = (string1, string2) => string1 ++ string2
let toIgnoredName = concatStrings("_", _)

Received:

let concatStrings = (string1, string2) => string1 ++ string2
let toIgnoredName = () => concatStrings("_", _)
@cristianoc cristianoc added the bug label Apr 14, 2023
@cristianoc cristianoc added this to the v11.0 milestone Apr 14, 2023
cristianoc added a commit that referenced this issue Apr 14, 2023
@cristianoc
Example of broken formatting for foo(a,_) in uncurried mode.
9ff26dd 
See #6146
@cristianoc cristianoc mentioned this issue Apr 14, 2023
Merged
@cristianoc
Copy link
Collaborator

@DZakh thanks for the report.
Done here: #6148

Would you try a few more examples with that PR, see if there are no other corner cases missing?

@DZakh
Copy link
Contributor Author

DZakh commented Apr 14, 2023

Is there an instruction how to use the PR's version of the compiler?

@cristianoc
Copy link
Collaborator

Is there an instruction how to use the PR's version of the compiler?

Wait for CI to finish, and npm install the artifact.

cristianoc added a commit that referenced this issue Apr 14, 2023
@cristianoc
Example of broken formatting for foo(a,_) in uncurried mode. (#6148)
cde772a 
* Example of broken formatting for foo(a,_) in uncurried mode.

See #6146

* Fix pretty printing.

Fixes #6148

* Fix second case.

* Update CHANGELOG.md

* Somehow roundtrip tests are not happy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v11.0
Development

No branches or pull requests
2 participants
@cristianoc @DZakh