Skip to content

Some paths use forward slashes on windows #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abhirmathur opened this issue Jul 21, 2016 · 2 comments
Closed

Some paths use forward slashes on windows #543

abhirmathur opened this issue Jul 21, 2016 · 2 comments
Labels
bug

Comments

@abhirmathur
Copy link
Contributor

When using the windows compiler it mixes back and forward slashes like:

bs-platform\lib/amdjs\array

when on unix I get the correct path

bs-platform/lib/amdjs/array
@bobzhang bobzhang added the bug label Jul 21, 2016
@bobzhang
Copy link
Member

we should don a sanity check when generating paths to make sure it is always '/'

bobzhang pushed a commit that referenced this issue Jul 21, 2016
fix windows build #543
e8f1014
bobzhang pushed a commit that referenced this issue Jul 21, 2016
fix windows build #543
91f8c1a
bobzhang added a commit that referenced this issue Jul 21, 2016
@bobzhang
Merge pull request #544 from bloomberg/windows_build
9a084eb 
fix windows build #543
@bobzhang
Copy link
Member

see #543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobzhang @abhirmathur