Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradually deprecate -bs-no-version-header #4735

Closed
chenglou opened this issue Oct 1, 2020 · 0 comments
Closed

Gradually deprecate -bs-no-version-header #4735

chenglou opened this issue Oct 1, 2020 · 0 comments

Comments

@chenglou
Copy link
Member

chenglou commented Oct 1, 2020

This flag was needed because the output's header used to include the version of the compiler, which caused lots of noisy changes each codebase compiler upgrade. But now it's no longer included, and is a stable message that the output is generated by ReScript. No need for such header anymore.
bobzhang added a commit that referenced this issue Oct 13, 2020
@bobzhang
Merge pull request #4746 from rescript-lang/fix_4735
a88c523 
fix #4735, make -bs-no-version-header internal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chenglou