Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading message about error location in BS 7 #4006

Closed
fhammerschmidt opened this issue Dec 4, 2019 · 2 comments · Fixed by #4029
Closed

Misleading message about error location in BS 7 #4006

fhammerschmidt opened this issue Dec 4, 2019 · 2 comments · Fixed by #4029

Comments

@fhammerschmidt
Copy link
Member

fhammerschmidt commented Dec 4, 2019

File "  /[redacted]/bs-7-example/src/SampleError.re", line 2, characters 6-6:
Error: Unclosed "{" (opened line 1, column 8)

  We've found a bug for you!
  /[redacted]/bs-7-example/src/SampleError.re
  
  There's been an error running Reason's parser on a file.
  The error location should be slightly above this message.
  Please file an issue on github.com/facebook/reason. Thanks!

I think it is strange now with Reerror in BuckleScript 7.0.0, that the error message still says that

The error location should be slightly above this message

When actually the location is exactly where the error happens (which is really nice)

I would change that to be less confusing, for example

If you cannot locate the error with the help of the message above, the error location should be slightly above this message

But I am not sure whether that is too long?

@bobzhang
Copy link
Member

bobzhang commented Dec 5, 2019

cc @chenglou

@bobzhang
Copy link
Member

@fhammerschmidt would you mind send a PR on this error message tweak? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants