-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.2.0/6.1.0 fails to install on windows #3843
Comments
can you try |
just tried that. Both global and local install fails. log below for local install.
|
Note 5.0.6 installs and works correctly on windows. |
I tested on my windows laptop. works good to me
|
On a clean dir the first command succeeds.
However, the second one is failing.
Tried the command manually too but got an error again,
It seems
|
That's quite weird, if you go to install.js around lines 100, ninja.exe should be there |
Ran
again for clean install. Fails consistently in function
This also seems to corrupt ninja.exe somehow. since running In summary, the error seems to originate from Error:
|
are you running this on cygwin |
This also looks weird to me, since copyPrebuiltCompilers is between lines 229 and lines 237 (not lines 253) |
My stack: Node.
Npm:
I am trying to trace through EDIT: update see the comment below for latest. |
Forgot to add. I am using native windows. No cygwin. |
Ok, I think I finally nailed down the issue. It seems our corporate anti-virus stops/deletes the
Not sure if the anti-virus issue is a false positive but the version of ninja included with |
The ninja bianries are built on my machine, can you report it to your corporate IT for more details?
发自我的iPhone
…------------------ Original ------------------
From: Bikal Lem <notifications@github.com>
Date: Tue,Sep 24,2019 6:33 PM
To: BuckleScript/bucklescript <bucklescript@noreply.github.com>
Cc: Hongbo Zhang <bobzhang1988@gmail.com>, Comment <comment@noreply.github.com>
Subject: Re: [BuckleScript/bucklescript] 5.2.0/6.1.0 fails to install on windows (#3843)
Ok, I think I finally nailed down the issue. It seems our corporate anti-virus stops/deletes the ``ninja.exeincluded withbs-platform``` version greater than 5.0.6. ```5.0.6``` is the last know good version which seems to work okay, i.e. no antivirus issues. Not sure what is the diff between ```ninja.exe``` included with ```5.0.6``` and ```5.1.0/5.2.0/6.1.0```. However, if I copy the ninja included in ```5.0.6``` to the ```5.1.0/5.2.0/6.1.0``` then the installations succeeds. Here are the steps that I followed.
npm i bs-platform@6.1.0 --ignore-scripts
Browse to .\node_modules\bs-platform\vendor\ninja\snapshot and copy the ninja files from version 5.0.6 to this folder.
Run node .\node_modules\bs-platform\scripts\install.js.
Not sure if the anti-virus issue is a false positive but the version of ninja included with 5.1.0/5.2.0/6.1.0 seems to trigger it when calling cp.execFileSync. After which the anti-virus deletes the ninja executable. Which explains why subsequent running of node .\node_modules\bs-platform\scripts\install.js fails. Could this perhaps be a security incident? i.e. the ninja binaries are compromised somehow??
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@bikallem The ninja prebuilt binary was introduced in this commit 7b1c390 |
@bobzhang It seems ninja.exe being classified as a trojan is a persistent issue. Are you open to a rewrite of |
closed, moving discussions into #3850 |
Just tried to install 5.2.0 on windows using the following cmd
npm -g install bs-platform@5.2.0
.It fails with the following error log.
The text was updated successfully, but these errors were encountered: