Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@bs.deriving jsConverter] not working for polymorphic variant => string converter #3557

Closed
yawaramin opened this issue May 21, 2019 · 1 comment
Closed

[@bs.deriving jsConverter] not working for polymorphic variant => string converter #3557

yawaramin opened this issue May 21, 2019 · 1 comment
Labels
playground

Comments

@yawaramin
Copy link
Contributor

For example, the following code:

type adapter = [ `idb  | `leveldb  | `http ] [@@bs.deriving jsConverter]

Gives the error:

We've found a bug for you!
OCaml preview

The value binarySearch can't be found in Js.MapperRt

As seen here: https://reasonml.github.io/en/try.html?rrjsx=true&ocaml=C4TwDgpgBAhgJjMwICcoF4oG0oAMCWcARlFAD54A2EAbhJcaRbgBbDBhQC62AAr0QDOAOjip8NfADsA5lABWggMIB7KXRTIUXAFBA
bobzhang added a commit that referenced this issue May 21, 2019
@bobzhang
Merge pull request #3558 from BuckleScript/fix_3557
8046bc8 
fix #3557
@bobzhang
Copy link
Member

@yawaramin the missing cmi is added in repl.js scripts. Reason playground may be needed to updated accordingly. cc @rickyvetter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
playground
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yawaramin @bobzhang